This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: do not recreate database record for category setting #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the category settings page if the voting plugin is enabled and user clicks “Save Category” button then the database record for the `discourse_voting_category_settings` table is deleted and recreated every time the button is pressed. This commit checks for existing record and prevents creation of new database record
ZogStriP
approved these changes
May 12, 2022
nattsw
reviewed
May 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the category settings page if the voting plugin is enabled and user
clicks “Save Category” button then the database record for the
discourse_voting_category_settingstable is deleted and recreatedevery time the button is pressed. This commit checks for existing record
and prevents creation of new database record