UX: Show the quoted user's avatar in rich editor quotes - #42446
Draft
renato wants to merge 2 commits into
Draft
Conversation
renato
marked this pull request as draft
August 7, 2026 18:55
renato
force-pushed
the
prosemirror-quote-avatar
branch
2 times, most recently
from
August 7, 2026 19:59
108b8a2 to
a308518
Compare
Glimmer node views always rendered a generic div/span wrapper and
appended the editable content to it, so nodes needing specific markup
had to use a plain node view class instead.
Node view descriptors now accept `tag`, `contentTag` and `attrs`, and
components with content receive it as their block, placing it with
`{{yield}}`.
renato
force-pushed
the
prosemirror-quote-avatar
branch
from
August 7, 2026 21:13
a308518 to
138ecaa
Compare
renato
force-pushed
the
prosemirror-quote-avatar
branch
from
August 8, 2026 18:21
138ecaa to
6db5c9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quotes in the rich editor showed only the quoted user's name, while cooked posts also showed their avatar. Glimmer node views always rendered a generic
div/spanwrapper and appended the editable content to it, so a quote could not produce theaside.quote > .title + blockquotemarkup its styles rely on.This change lets node view descriptors declare their
tag,contentTagandattrs, and hands components the editable content as their block to place with{{yield}}, then uses that to render the quoted user's avatar in the quote header, matching the cooked output.