DEV: Write our own mutant skill#64
Merged
Merged
Conversation
gschlager
force-pushed
the
rewrite-mutant-skill
branch
4 times, most recently
from
2995fa9 to
3373950
Compare
Replaces the vendored copy of upstream's SKILL.md with a playbook written for this project. It carries the markbridge-specific conventions and the recipes from the coverage push and the perf campaign: byte-boundary probe specs, identity assertions for allocation-equivalents, walk-depth requirements, the describe-name test-selection gotcha, fast-path ignore etiquette, the accepted-timeouts convention, and the Integer()-octal simplification trap. Upstream's playbook stays linked as reference reading. AGENTS.md's mutation-testing section shrinks to a pointer at the skill — one canonical home per rule — except the MarkdownEscaper benchmark rule, which moves to the always-loaded Performance Notes because escaper edits happen outside mutation work too. Also retires the Ruby PRISM bug (#22002) from the mutation rationale: it is closed upstream and no longer reproduces on the Ruby the mutation job runs (4.0.5), and the code-level workarounds left the repo long ago. The accepted-timeouts policy stands on its own merits — loop-progress guards cost measurable time on hot loops and add mutation surface of their own.
gschlager
force-pushed
the
rewrite-mutant-skill
branch
from
8e2fb2e to
d3230b8
Compare
gschlager
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the vendored copy of upstream's SKILL.md with a playbook written for this project. It keeps the factual mechanics and folds in what a generic document can't know: our wrapper and mutant.yml conventions, the describe-name test-selection gotcha, byte-boundary probe specs, identity assertions for allocation-equivalents, the accepted-timeouts convention, fast-path ignore etiquette, and the
Integer()octal trap. Upstream's playbook stays linked at the bottom as reference reading.AGENTS.md's mutation-testing section shrinks to a pointer at the skill — one canonical home per rule — except the MarkdownEscaper benchmark rule, which moves to the always-loaded Performance Notes because escaper edits happen outside mutation work too.
Also retires the Ruby PRISM bug (#22002) from the mutation rationale: it's closed upstream and no longer reproduces on Ruby 4.0.5 (what the mutation job runs), and the code-level workarounds left the repo long ago. The accepted-timeouts policy stays for its real reasons — loop guards cost measurable time on hot loops and add mutation surface of their own.