ext4: stop discarding the cause of directory read failures - #421
Merged
deitch merged 1 commit intoAug 3, 2026
Merged
Conversation
readDirWithMkdir's per-level readDirectory call dropped its error entirely, collapsing every possible cause -- checksum mismatches, unparseable dirents, htree rejections, extent tree failures, inode read failures -- into a single opaque "failed to read directory <path>" with no detail at all. The mkSubdir wrapper a few lines above had the same problem. The root-level readDirectory call did include the error text (%v), but not in a form errors.Is/errors.As can reach. Wrap all three with %w so the real cause survives to the caller. Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
deitch
approved these changes
Aug 3, 2026
deitch
left a comment
deitch
left a comment
Collaborator
There was a problem hiding this comment.
This seems rather obvious in retrospect, doesn't it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readDirWithMkdir's per-level readDirectory call dropped its error entirely, collapsing every possible cause -- checksum mismatches, unparseable dirents, htree rejections, extent tree failures, inode read failures -- into a single opaque "failed to read directory " with no detail at all. The mkSubdir wrapper a few lines above had the same problem. The root-level readDirectory call did include the error text (%v), but not in a form errors.Is/errors.As can reach.
Wrap all three with %w so the real cause survives to the caller.