Fix false error in check_install_rpm #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
The unit tests were failing (because of the output change), so I cancelled them. @atheurer, I'll fix up the unit tests and send you another tarball. |
If a package was requested but did not include a version, and the package was already installed, this function would return an error, which is incorrect.
I will update the unittest files to fix this.
These were created prviously while PBENCH_debug_mode was set to "1", which is not the default.
atheurer
force-pushed
the
base_check_install_rpm
branch
from
31b09f3 to
dc9096f
Compare
Contributor
Author
|
The unittests pass, but the TravisCI still fails (no idea why) |
Member
|
Yes, that's weird - I'm checking it. |
Nick's patch targeted at Andrew's working branch
atheurer
added a commit
that referenced
this pull request
Mar 10, 2016
Fix false error in check_install_rpm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to PCP branch