Pcp #183
Closed
Pcp #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The post-processing is done by a pcp-native binary, so there is no unit test for this. We assume pcp untility "pmlogger" is good.
New function to start pcp More error logging Exit if check_install_rpm fails
Contributor
Author
|
PR #182 is required before this pull request is merged. PCP installs with no version specified, because we do not maintain the package within pbench. PR #182 resolves an issue where check_install_rpm returned code "1" when the package was already installed, and the package version was not provided with check_install_rpm |
Member
|
@atheurer: I've got a pcp unit test case (needs an updated unittests script in tool-scripts/postprocess). I've tested on a branch with master + atheurer-sar + atheurer-PR#182 + atheurer-pcp. |
Contributor
Author
|
ok I think you can send me a pull request for that, or send it to me directly. |
Unit test case for pcp.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pcp tool