Adds tool script for performance co-pilot. #205
Merged
+11,152
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Post-process script for performance co-pilot. The post-processing is done by a pcp-native binary. We assume pcp utility "pmlogger" is good. Add default config file for pcp's pmlogger. Update pcp to support sample interval. Update how pcp creates/uses pmlogger config. Add more robust checks for pcp install & start: - New function to start pcp. - More error logging. - Exit if check_install_rpm fails. Bug fix in tool-scripts/postprocess/unittests: make i local. Bug fix in pcp-postprocess: add space in test. Unit test case for pcp: Mock out pminfo and pmdumptext so that we eliminate dependencies on pcp version. The unit test only tests for the HTML files that are produced by the rudimentary pcp-postprocess script.
Closed
ndokos
added a commit
that referenced
this pull request
Mar 21, 2016
Adds tool script for performance co-pilot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-process script for performance co-pilot.
The post-processing is done by a pcp-native
binary. We assume pcp utility "pmlogger" is good.
Add default config file for pcp's pmlogger.
Update pcp to support sample interval.
Update how pcp creates/uses pmlogger config.
Add more robust checks for pcp install & start:
Bug fix in tool-scripts/postprocess/unittests: make i local.
Bug fix in pcp-postprocess: add space in test.
Unit test case for pcp: Mock out pminfo and pmdumptext so that we
eliminate dependencies on pcp version. The unit test only tests for
the HTML files that are produced by the rudimentary pcp-postprocess
script.