Fix pbench-register-tool-set argument handling #2904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndokos
added
bug
Agent
tools
ndokos
added a commit
to ndokos/pbench
that referenced
this pull request
Jun 17, 2022
…ted-system-analysis#2904 Fixes distributed-system-analysis#2903 Backport of distributed-system-analysis#2904 Invoking pbench-register-tool-set with a named toolset argument, e.g. pbench-register-tool-set light ignores the named argument, and substitutes the default tool set, resulting in a deprecation warning and registration of the default tool set. The option-handling code does one extra shift of the argument list falling off the end. The fix just eliminates the extra shift. Also add a simple unit test for this case.
Fixes distributed-system-analysis#2903 Invoking pbench-register-tool-set with a named toolset argument, e.g. pbench-register-tool-set light ignores the named argument, and substitutes the default tool set, resulting in a deprecation warning and registration of the default tool set. The option-handling code does one extra shift of the argument list falling off the end. The fix just eliminates the extra shift. Also add a simple unit test for this case.
ndokos
force-pushed
the
fix-pbench-register-tool-set
branch
from
d3dad89 to
4b7833d
Compare
dbutenhof
approved these changes
Jun 17, 2022
portante
approved these changes
Jun 17, 2022
ndokos
added a commit
to ndokos/pbench
that referenced
this pull request
Jun 17, 2022
Following a comment by @dbutenhof on PR#2904 (actually, its sibling backporting to b0.71), this PR adds a few more tests for `pbench-register-tool-set'. There is no plan to backport this PR to b0.71 however.
portante
pushed a commit
that referenced
this pull request
Jun 17, 2022
Following a comment by @dbutenhof on PR #2904 (actually, its sibling PR back-porting to b0.71), this PR adds a few more tests for `pbench-register-tool-set'.
portante
pushed a commit
that referenced
this pull request
Jun 17, 2022
Fixes #2903 Back port of #2904 (6ba02ca). Invoking pbench-register-tool-set with a named toolset argument, e.g. pbench-register-tool-set light ignores the named argument, and substitutes the default tool set, resulting in a deprecation warning and registration of the default tool set. The option-handling code does one extra shift of the argument list falling off the end. The fix just eliminates the extra shift. Also add a simple unit test for this case.
portante
pushed a commit
to portante/pbench
that referenced
this pull request
Jun 23, 2022
Back-port of PR distributed-system-analysis#2908 (commit f3eca50). Following a comment by @dbutenhof on PR distributed-system-analysis#2904 (actually, its sibling PR back-porting to b0.71), this PR adds a few more tests for `pbench-register-tool-set'.
portante
pushed a commit
that referenced
this pull request
Jun 24, 2022
Back-port of PR #2908 (commit f3eca50). Following a comment by @dbutenhof on PR #2904 (actually, its sibling PR back-porting to b0.71), this PR adds a few more tests for `pbench-register-tool-set'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2903
Invoking pbench-register-tool-set with a named toolset argument, e.g.
ignores the named argument, and substitutes the default tool set, resulting in a deprecation warning and registration of the default tool set.
The option-handling code does one extra shift of the argument list falling off the end. The fix just eliminates the extra shift.
Also add a simple unit test for this case.