Skip to content

Fix pbench-register-tool-set argument handling #2904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Fix pbench-register-tool-set argument handling #2904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions agent/util-scripts/gold/pbench-register-tool-set/test-11.18.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
+++ Running test-11.18 pbench-register-tool-set light
"vmstat" tool is now registered for host "testhost.example.com" in group "default"
--- Finished test-11.18 pbench-register-tool-set (status=0)
+++ pbench tree state
/var/tmp/pbench-test-utils/pbench
/var/tmp/pbench-test-utils/pbench/pbench.log
/var/tmp/pbench-test-utils/pbench/tmp
/var/tmp/pbench-test-utils/pbench/tools-v1-default
/var/tmp/pbench-test-utils/pbench/tools-v1-default/testhost.example.com
/var/tmp/pbench-test-utils/pbench/tools-v1-default/testhost.example.com/vmstat
=== /var/tmp/pbench-test-utils/pbench/tools-v1-default/testhost.example.com/vmstat:
--interval=3
--- pbench tree state
+++ pbench.log file contents
[debug][1900-01-01T00:00:00.000000] tool_opts: "--interval=3"
[info][1900-01-01T00:00:00.000000] "vmstat" tool is now registered for host "testhost.example.com" in group "default"
--- pbench.log file contents
1 change: 0 additions & 1 deletion agent/util-scripts/pbench-register-tool-set
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ while true; do
exit 0
;;
--)
shift
break
;;
esac
Expand Down
3 changes: 2 additions & 1 deletion agent/util-scripts/unittests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@ declare -A tools=(
[test-11.15]="pbench-register-tool-set"
[test-11.16]="pbench-register-tool-set"
[test-11.17]="pbench-register-tool-set"
[test-11.18]="pbench-register-tool-set"
[test-17]="test-tm-start-bad-group"
[test-18]="test-tm-stop-bad-group"
[test-19]="test-tool-trigger"
Expand Down Expand Up @@ -475,7 +476,7 @@ declare -A options=(
[test-11.15]="--remotes=@non-existent-file"
[test-11.16]="--remotes=@${_testdir}/tmp/good-remote-file"
[test-11.17]="--remotes=@${_testdir}/tmp/empty-remote-file"

[test-11.18]="light"
# pbench-move-results
[test-20]="--help"
# pbench-move-results - no args, nothing to do
Expand Down