fix: update coinbase test to match refactored production code - #2
Merged
Conversation
- Replace named types (Account, Currency, Balance, PriceData) with anonymous map structures matching production code - Fix Client initialization to use apiKeyID/privateKey fields instead of removed apiKey/apiSecret fields - Generate a real ed25519 key for JWT auth in tests Fixes #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken tests in
backend/internal/connectors/coinbase/coinbase_test.go. The production code was refactored to use ed25519 JWT auth and anonymous struct types in API responses, but the test file wasn't updated.Changes
Account,Currency,Balance,PriceData) with anonymousmap[string]interface{}that match the current response structureClientinitialization:apiKey/apiSecret→apiKeyID/privateKey(ed25519)crypto/ed25519andcrypto/randimports to generate a real test key for JWT signingRelated
Fixes #1