Allow recursive extend in rendering#6564
Merged
goutnet merged 7 commits intodjango-cms:developfrom May 19, 2021
Merged
Conversation
Contributor
Author
|
At the moment CI on base branch is failing, I will rebase when |
https://docs.djangoproject.com/en/dev/releases/1.9/#template-loader-apis-have-changed Recursive template extending works since Django 1.9, but it was not working when rendering placeholders. Adding the extend node origin to the template in the context allows recursion to work.
stefanw
force-pushed
the
recursive-extend
branch
from
f5e3603 to
9316967
Compare
Member
|
@stefanw would you be able to open the PR against develop? |
Contributor
Author
|
@FinalAngel I changed the base branch to develop. |
goutnet
approved these changes
May 19, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6563
Proposed changes in this pull request
Add the ability to extend templates recursively to Django CMS. This is possible in Django since 1.9.
Documentation checklist