Skip to content

Conversation

@jrief
Copy link
Collaborator

@jrief jrief commented Aug 8, 2022

Description

Apparently someone (myself?) forgot to recompile the SCSS files after changing them.
This has the unnice effect that some widgets are visually broken.

Screenshot 2022-08-08 at 10 08 20

After running gulp sass they look nice again:

Screenshot 2022-08-08 at 10 09 06

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #1307 (cdc57ce) into master (fd60809) will increase coverage by 11.45%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1307       +/-   ##
===========================================
+ Coverage   60.75%   72.21%   +11.45%     
===========================================
  Files          72       72               
  Lines        3239     3239               
  Branches      563      563               
===========================================
+ Hits         1968     2339      +371     
+ Misses       1117      734      -383     
- Partials      154      166       +12     
Impacted Files Coverage Δ
filer/admin/tools.py 76.81% <0.00%> (+1.44%) ⬆️
filer/admin/forms.py 68.29% <0.00%> (+2.43%) ⬆️
filer/models/filemodels.py 86.54% <0.00%> (+3.58%) ⬆️
filer/templatetags/filer_tags.py 41.50% <0.00%> (+5.66%) ⬆️
filer/templatetags/filer_admin_tags.py 86.56% <0.00%> (+5.97%) ⬆️
filer/models/abstract.py 81.51% <0.00%> (+7.56%) ⬆️
filer/utils/filer_easy_thumbnails.py 84.48% <0.00%> (+8.62%) ⬆️
filer/models/virtualitems.py 94.36% <0.00%> (+9.85%) ⬆️
filer/admin/patched/admin_utils.py 88.09% <0.00%> (+10.71%) ⬆️
filer/utils/loader.py 80.00% <0.00%> (+13.33%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vinitkumar vinitkumar merged commit e019478 into master Aug 8, 2022
@vinitkumar vinitkumar deleted the recompile-sass branch August 8, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants