-
Notifications
You must be signed in to change notification settings - Fork 31
feat: match django-cms core test matrix #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the GitHub Actions workflow to align the CI test matrix with the Django-CMS core compatibility matrix, adds pip caching to speed up runs, and modernizes the dependency installation step for consistent, reproducible installs. Class diagram for updated CI workflow stepsclassDiagram
class SetupPythonStep {
+python-version
+cache
}
class InstallDependenciesStep {
+system-packages
+upgrade-pip
+install-uv
+requirements-file
}
class RunCoverageStep {
+pytest
+coverage
}
SetupPythonStep <--> InstallDependenciesStep
InstallDependenciesStep <--> RunCoverageStep
Flow diagram for modernized dependency installation in CI workflowflowchart TD
A["Install system dependencies"] --> B["Upgrade pip and install uv"]
B --> C["Install Python dependencies with uv"]
C --> D["Run tests with coverage"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/codecov.yml:59-61` </location>
<code_context>
uses: actions/setup-python@v6
with:
python-version: ${{ matrix.python-version }}
+ cache: 'pip'
- name: Install dependencies
run: |
</code_context>
<issue_to_address>
**suggestion:** Enabling pip cache may not benefit 'uv' installs.
Because 'uv' is used for installation, pip cache may be redundant or misleading if 'uv' does not interact with it.
```suggestion
with:
python-version: ${{ matrix.python-version }}
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
- Coverage 89.13% 89.13% -0.01%
==========================================
Files 124 124
Lines 3387 3386 -1
Branches 288 288
==========================================
- Hits 3019 3018 -1
Misses 252 252
Partials 116 116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…t/upgrade-python-ci
fsbraun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @vinitkumar !
Upgrade Python CI Test Matrix
This PR updates the CI/CD test matrix to align with django-cms core testing standards and support the latest Python and Django versions.
Changes
Python Version Support:
Django Version Support:
Test Matrix Exclusions:
CI Improvements:
pip installtouv pip installfor faster dependency resolutionThese changes ensure the package is tested against all supported Python and Django version combinations while maintaining compatibility with the django-cms ecosystem.