Skip to content

Conversation

@vinitkumar
Copy link
Member

@vinitkumar vinitkumar commented Oct 24, 2025

Upgrade Python CI Test Matrix

This PR updates the CI/CD test matrix to align with django-cms core testing standards and support the latest Python and Django versions.

Changes

Python Version Support:

  • Drop Python 3.9 support
  • Add Python 3.14 support
  • Test matrix now covers Python 3.10-3.14

Django Version Support:

  • Add Django 6.0 with CMS 5.0 to test matrix

Test Matrix Exclusions:

  • Python 3.14 only compatible with Django 5.2+ (excluded from Django 4.2, 5.0, and 5.1)
  • Python 3.10 and 3.11 excluded from Django 6.0 (end of support)
  • Python 3.12 and 3.13 excluded from Django 4.2 with CMS 3.11

CI Improvements:

  • Enable pip caching in setup-python action
  • Switch from pip install to uv pip install for faster dependency resolution
  • Upgrade pip and uv before installing dependencies

These changes ensure the package is tested against all supported Python and Django version combinations while maintaining compatibility with the django-cms ecosystem.

@vinitkumar vinitkumar requested a review from fsbraun October 24, 2025 11:21
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the GitHub Actions workflow to align the CI test matrix with the Django-CMS core compatibility matrix, adds pip caching to speed up runs, and modernizes the dependency installation step for consistent, reproducible installs.

Class diagram for updated CI workflow steps

classDiagram
  class SetupPythonStep {
    +python-version
    +cache
  }
  class InstallDependenciesStep {
    +system-packages
    +upgrade-pip
    +install-uv
    +requirements-file
  }
  class RunCoverageStep {
    +pytest
    +coverage
  }

  SetupPythonStep <--> InstallDependenciesStep
  InstallDependenciesStep <--> RunCoverageStep
Loading

Flow diagram for modernized dependency installation in CI workflow

flowchart TD
  A["Install system dependencies"] --> B["Upgrade pip and install uv"]
  B --> C["Install Python dependencies with uv"]
  C --> D["Run tests with coverage"]
Loading

File-Level Changes

Change Details Files
Align GitHub Actions test matrix to match Django CMS core compatibility
  • Bump Python matrix from 3.10–3.13 to 3.10–3.14, dropping 3.9
  • Add dj60_cms50.txt to requirements-file list
  • Restructure exclude section for incompatible Python/Django-CMS combinations
  • Annotate compatibility constraints with inline comments
.github/workflows/codecov.yml
Enable pip caching in setup-python step
  • Add cache: 'pip' to actions/setup-python invocation
.github/workflows/codecov.yml
Improve dependency installation process for reproducibility
  • Switch to python -m pip to upgrade pip and install uv
  • Use uv pip install --system for installing test requirements
  • Keep OS-level libcairo2 and python3-dev installation
.github/workflows/codecov.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.github/workflows/codecov.yml:59-61` </location>
<code_context>
       uses: actions/setup-python@v6
       with:
         python-version: ${{ matrix.python-version }}
+        cache: 'pip'
     - name: Install dependencies
       run: |
</code_context>

<issue_to_address>
**suggestion:** Enabling pip cache may not benefit 'uv' installs.

Because 'uv' is used for installation, pip cache may be redundant or misleading if 'uv' does not interact with it.

```suggestion
      with:
        python-version: ${{ matrix.python-version }}
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.13%. Comparing base (8eb0431) to head (37767af).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   89.13%   89.13%   -0.01%     
==========================================
  Files         124      124              
  Lines        3387     3386       -1     
  Branches      288      288              
==========================================
- Hits         3019     3018       -1     
  Misses        252      252              
  Partials      116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vinitkumar !

@fsbraun fsbraun merged commit ec1da18 into main Oct 24, 2025
35 checks passed
@fsbraun fsbraun deleted the feat/upgrade-python-ci branch November 19, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants