Who are our active maintainers and who can perform reviews?

[Natgho]

Hi Guardians,

I recently started working on the project's maintenance. Thanks to @thclark , who was a huge help, and after a quick adaptation period, I am now reviewing tickets and making the necessary improvements/feature additions.

However, like any mortal human being, it's not fair to subject only Tom to the torture of reading intense and constant PR reviews.

I see that there are many admins and maintainers in the project, and I would like to ask for their support under this heading. Who has the time to read the PRs and is willing to volunteer?
@ad-m @BonaFideIT @brianmay @cmaggiulli @dpgraham4401 @lukaszb @michael-k

If you no longer wish to be part of the project, you can also indicate this under this heading.

However, these PRs need to be reviewed by another pair of eyes. This prevents incorrect updates and ensures that I am not the sole decision-maker.

[dpgraham4401]

Hey @Natgho glad Guardian is getting the TLC it deserves and I'm also glad you have a lot of time to devote.

I'm willing to spend time reviewing, but I'm also starting a new job and my time is limited.

EDIT: I would add a reminder that we're not paid to do this, and only can give the time that we have.

[Natgho]

Hey @Natgho glad Guardian is getting the TLC it deserves and I'm also glad you have a lot of time to devote.

I'm willing to spend time reviewing, but I'm also starting a new job and my time is limited.

EDIT: I would add a reminder that we're not paid to do this, and only can give the time that we have.

It means a lot to me that someone sees and appreciates this effort. It's great to hear that :) Django-guardian has become my personal passion, it's really a wonderful thing. I'll be around here as much as my time allows.

Congratulations on your new job, I hope it's a great start for you. We all have limited time, so I relax with DG whenever I can, for example :)

I know your time is limited, so (and to provide a roadmap for other maintainers who will read this) I'll list the PRs I've created here in order from those that can be reviewed quickly to the more complex ones, so that someone can see them, approve them, or comment on them;
#926 (just for adding code coverage)
#923 (perm checks for inactive users should behave the same as other functions / documentation)
#928 (actually bug fixing, but also check subgroups -it should be always-)
#924 ( group level permission check feature)
#927 (permission as a template feature)

[BonaFideIT]

We are a company in germany using guardian in our biggest software client. just a few guys implementing features / fixes if we need them / discover them. We will selectively spend time reviewing merge requests if we can find the time to give back to the community. Free time comes usually when we least suspect it and in bursts, so you can expect irregular sudden bursts of activity. ;)

[Natgho]

“Miracles happen when we least expect them.” (=

So when you don't have time, I expect you to review the PRs 🥇

[BonaFideIT]

sounds reasonable. ;)

[Natgho]

Are the other maintainers not active at all? @ad-m @brianmay @cmaggiulli @lukaszb @michael-k ?

[thclark]

It's more to honour the fact that they built this thing than anything else - think if you'd built something that earned 3.8k stars on github - that shows on your CV and part of your developer portfolio and shouldn't really be vapourised just because you're no longer active in the project. I suspect most have notifications for the repo turned off though.

[brianmay]

I only become a maintainer because I contributed one too many changes in 2015. Łukasz Balcerzak gave me admin access on 2015-11-11, at a time when he could not contribute anymore.

I think I was trying to fix djangorestframework in Debian - which for reasons I never understood - depended on guardian. I don't recall ever having used guardian in any of projects (could be mistaken here), and I definitely am not using it anymore now. So it doesn't really bother me if I am a maintainer or not. It seems like there are sufficient active maintainers to keep the project alive now.

[brianmay]

I never thought of mentioning this on my CV. Interesting idea here. Not sure I need to be an active maintainer though for that...

[Natgho]

Perhaps my words were misinterpreted because they were open to misinterpretation. I would like to express myself more clearly;

First of all, I have great respect for the maintainers who have brought the project to where it is today and have been participating for years. We are talking about a magnificent project with thousands of lines of code and 98% code coverage.

When I said, “If they are not going to contribute, what is the point of them remaining as maintainers?”, I was referring to their permissions on the repository. I certainly did not say it with the intention of disrespecting the contribution they made.

If they are still eager to contribute to the project, let's keep them on this list. If they are no longer interested (as is the case with many projects I was involved in but no longer need to use professionally and they took away my authority as well), keeping them on the list would serve no purpose other than sending them notifications they have already opted out of.

An issue has already been created to include the names of these valued maintainer (unless they specify otherwise) in both the project documentation (and the README file): #679

In order to include new maintainers in the project, the number of maintainers here should appear low, so that other developers might see it and think, “Oh, this project needs this kind of contribution,” giving them a chance to reach out to us active maintainer team. Frankly, a project with the current number of maintainers shouldn't need additional help, but in reality, Tom and I are working intensely here to get things done.

Since the PRs I created two weeks ago haven't been reviewed by anyone, they are still pending, and while I still have time to make extra improvements to them, I am forced to wait for someone else to review their PRs to avoid conflicting with myself.

In short, I would like to thank the maintainers who have written here and described their situations. If you are not considering contributing to the project at all, simply stating this is sufficient. With your consent, we can then take you out of the management role. Your names (unless you prefer otherwise) will be added to the places I mentioned as soon as possible. However, if you wish to participate, of course, you were all here long before me, and your contributions would be excellent.

[thclark]

OK @brianmay we'll remove you from the list so you don't get hassled so much! Thanks so much for your work over the years :)