Skip to content

Nit: Inaccurate help_text on client_secret field of AbstractApplication model #1628

@lrq315

Description

@lrq315

Describe the bug

help_text=_("Hashed on Save. Copy it now if this is a new secret."),

The help_text "Hashed on Save. Copy it now if this is a new secret." is only accurate when hash_client_secret=True. When hash_client_secret=False, the secret is stored as plain text, making this help_text misleading for users in the form.

Related PR: #1093 & #1311

To Reproduce
N/A

Expected behavior
The help_text should either be more generic to cover both cases, or be dynamically generated based on the hash_client_secret field value in the form.

Version
3.1.0

  • I have tested with the latest published release and it's still a problem.
  • I have tested with the master branch and it's still a problem.

Additional context
I’d be happy to raise an MR to resolve this. Please assign it to me if appropriate.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions