Skip to content

Conversation

@lrq315
Copy link

@lrq315 lrq315 commented Dec 15, 2025

Fixes #1628

Description of the Change

  • dynamic help text for client_secret based on hash_client_secret in both the Admin and Registration forms
  • add Chinese translation; remaining updates will be handled in a separate PR
  • fix the local test-idp for e2e testing
    admin_form
    registration_form

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS
  • tests/app/idp updated to demonstrate new features
  • tests/app/rp updated to demonstrate new features

@lrq315 lrq315 force-pushed the bug/1628/client_secret_help_text branch from 18047ab to b7273a7 Compare December 16, 2025 02:55
@lrq315 lrq315 changed the title WIP: chore: dynamic help_text for client_secret chore: dynamic help_text for client_secret Dec 16, 2025
@lrq315 lrq315 marked this pull request as ready for review December 16, 2025 04:07
@n2ygk
Copy link
Contributor

n2ygk commented Dec 16, 2025

Wow, that's a lot of changes. @dopry are you OK with this much code change to implement this relatively minor UI fix?

Also please wait on #1631 to be merged and rebase to resolve the failed 3.14 test.

@n2ygk n2ygk requested a review from dopry December 16, 2025 17:54
@lrq315
Copy link
Author

lrq315 commented Dec 17, 2025

Sorry—looking back, it does seem that the changes may have been a bit over-scoped. I should have checked with you on the scope in advance. Please feel free to let me revert the form changes and just update the text directly.

As for the other E2E test IdP mitigations, I think they might still be helpful for others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nit: Inaccurate help_text on client_secret field of AbstractApplication model

2 participants