Skip to content

Conversation

@n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Dec 16, 2025

testing for <= 3.14 breaks on minor releases like 3.14.2

Description of the Change

Fixed pyproject.toml to test for <3.15

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS
  • tests/app/idp updated to demonstrate new features
  • tests/app/rp updated to demonstrate new features

@n2ygk
Copy link
Contributor Author

n2ygk commented Dec 16, 2025

@dopry not clear to me how uv.lock gets updated. I tried uv lock but it didn't change. Is this lock file even supposed to be checked in to the project?

@n2ygk n2ygk requested a review from dopry December 16, 2025 17:45
@n2ygk n2ygk marked this pull request as ready for review December 16, 2025 17:45
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Python 3.14 and 3.15 release manager here! 👋

I strongly recommend against an upper cap.

First, by disallowing installation on 3.15 (currently in alpha), you're preventing people testing their own code on 3.15. I would really like people to be able to test their code on 3.15 to find and report bugs in Python so we can fix them before the big release in October. Also to help prepare their own code for 3.15.

Not only those who depend on django-oauth-toolkit, but those who depend on dependencies of django-oauth-toolkit. And so on down the chain.

But more importantly, it's too late to add any top version here, you would have needed to do it from day one (or else need to yank or delete all past releases!).

For example, if you release django-oauth-toolkit 3.2.0 with <=3.15 and I try and install with Python 3.15, I'll get the last version available without the top pin, 3.1.0.

Fast forward a year or two. Maybe you have <=3.17, and have released django-oauth-toolkit 5.1.0 or something. I try and install with 3.17, and end up with 3.1.0 from way back in 2025, which is definitely not intended.

See https://iscinumpy.dev/post/bound-version-constraints/ for the long version.

@n2ygk
Copy link
Contributor Author

n2ygk commented Dec 17, 2025

@dopry over to you for your review of the suggestion not to set an upper bound on requirements. Testing versions will continue to need to be update as new python releases are publshed.

n2ygk and others added 2 commits December 17, 2025 11:25
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants