Fix <greeting> format#92
Merged
Merged
Conversation
Owner
|
Can you split this into multiple commits? Maybe like:
|
valkum
force-pushed
the
fix-greeting-type
branch
2 times, most recently
from
8a4412d to
e3bc249
Compare
Contributor
Author
|
Split into two fix commits and a cleanup commit. I hope tests run through now; they used a partial checkout in an earlier run, it seems. |
The types from <greeting> are not 100% compatible with <login>. This is the first part of fixing this.
djc
reviewed
Jun 2, 2026
The fields in <svcMenu> can not be passed to <login> directly. Reusing the type made this too easy. Instead ServiceMenu now uses it's own Services higher level abstraction type.
<greeting> can contain multiple <lang> objects. The previous version tried to reuse types used in <login> but they are incompatible
djc
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 5730 allows multiple
<lang>elements in a<greeting>. If a server advertises multiple languages, the deserialization failed.The previous version tried to reuse types used in . Per RFC these are not identical.
I moved the types only used in the
<login>command to theloginmodule and introduced new ones for<greeting>.I tried to keep breaking changes minimal; migrations should thus be easy.
I kept the
ServiceMenubut flattened theOptions, as they no longer made sense in this context.You can no longer pass the options from the to login, you need to select a language. Language selection is left to the user.