Disable CEA_BUILD_TESTING on Windows bindc CI legs - #213
Merged
Conversation
djkees
marked this pull request as ready for review
September 4, 2026 15:27
djkees
added a commit
that referenced
this pull request
Sep 4, 2026
* Build GFE/pFUnit on Windows bindc CI legs * Disable CEA_BUILD_TESTING on Windows bindc CI legs instead of building GFE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The three Windows
bindcmatrix legs (windows-latest / intel / intel,windows-latest / gcc / gcc,windows-latest / msvc / intel) configure with-DCEA_BUILD_TESTING=ONbut never actually built GFE/pFUnit, socea_core_testwas silently absent there. That gap was invisible until the "fail visibly when pFUnit is missing" change (#209, now onmain) added a placeholder test that fails loudly instead — which is exactly what surfaced this as a Windows CI failure onmainright after #209 merged.An earlier version of this PR tried building GFE/pFUnit on Windows to get real coverage there, but that uncovered a chain of Windows-only gaps in GFE's own build (skipped GFE checkout, gfortran's missing
_WIN32predefine, a missingCMAKE_PREFIX_PATH, and finally a missingm4dependency for thegFTLsubmodule) with no guarantee that was the last one, especially for themsvc/intelleg's unusual mixed toolchain. Given thebindcjob's actual purpose is exercising C-binding builds across toolchains, not the Fortran core suite, this PR now just makes the Windows legs stop claiming test coverage they never had.Changes
Configure (Ninja): pass-DCEA_BUILD_TESTING=OFFinstead ofONwhenrunner.os == 'Windows'(Linux/macOS unaffected).Configure (msvc): pass-DCEA_BUILD_TESTING=OFF(this step only ever runs on Windows).Testing
Compatibility / Numerical behavior
CI-workflow-only change; no solver, algorithm, or data file touched. No test coverage is actually lost —
cea_core_testwas never built or run on these Windows legs before either; it was just silently absent instead of openly reporting so. The Fortran core suite remains covered by thepfunit-testsjob (ubuntu-22.04 / gcc 11).Drafted with Claude's assistance.
main(33775501053), and this PR's own two CI runs (which caught the additional GFE/pFUnit gaps before landing on this simpler fix).source/CMakeLists.txtand the top-levelCMakeLists.txtthatcea_core_testis only ever registered whenCEA_BUILD_TESTING AND PFUNIT_FOUND, so turning testing off where pFUnit was never built removes only the loud placeholder failure, not any real test.