Skip to content

Feature/json requests#1

Merged
djworth merged 9 commits into
djworth:masterfrom
inteq:feature/json-requests
Jul 19, 2014
Merged

Feature/json requests#1
djworth merged 9 commits into
djworth:masterfrom
inteq:feature/json-requests

Conversation

@inteq

@inteq inteq commented Jul 18, 2014

Copy link
Copy Markdown

I have created a branch from your work that allows the user of this api to build requests which are encoded in json or xml.

I also added more of a package structure , so that extensions to the library are a bit easier to make, instead of everything living in one file. Lastly, the package can be installed using setuptools.

@inteq

inteq commented Jul 18, 2014

Copy link
Copy Markdown
Author

I updated the request builder in order to provide a default for the class and object which are used to build requests using a json or xml encoding.

@djworth

djworth commented Jul 18, 2014

Copy link
Copy Markdown
Owner

@inteq thanks for the PR. I'll take a look this evening and provide feedback.

@djworth

djworth commented Jul 19, 2014

Copy link
Copy Markdown
Owner

looks like a lot of good stuff in here. Let's merge it in.... I'm going to setup some tests and tox for multi python version support.

Thanks for the great work!

djworth added a commit that referenced this pull request Jul 19, 2014
@djworth
djworth merged commit 788003e into djworth:master Jul 19, 2014
@inteq
inteq deleted the feature/json-requests branch July 19, 2014 05:20
@inteq

inteq commented Jul 19, 2014

Copy link
Copy Markdown
Author

Thanks for taking the time to look at my changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants