Force unwrap key string when fetching from localStorage #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xWDG
requested changes
Mar 16, 2018
Collaborator
0xWDG
left a comment
0xWDG
left a comment
There was a problem hiding this comment.
Please see my comment:
Is it maybe better to use
if let LSvalue = key {
let newKey = "WSLS:\(host):\(LSvalue)"
// ...
}otherwise, it will crash if no value is given, can you please test it and update your pull request?
Thanks in advance!
WebShell/WSInjector.swift
Outdated
| let getFromLocal: @convention(block)(NSString!) -> String = {(key: NSString!) in | ||
| let host: String = (self.mainWebview.mainFrame.dataSource?.request.url?.host)! | ||
| let newKey = "WSLS:\(host):\(key)" | ||
| let newKey = "WSLS:\(host):\(key!)" |
Collaborator
There was a problem hiding this comment.
Is it maybe better to use
if let LSvalue = key {
let newKey = "WSLS:\(host):\(LSvalue)"
}otherwise, it will crash if no value is given, can you please test it and update your pull request?
Contributor
Author
There was a problem hiding this comment.
You are right of course. I'm pushing the changes.
Contributor
Author
|
Updated the code to prevent crashes. |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me an embarrassingly long time to find this bug.
I have been trying to setup The Lounge as a WebShell app, but sessions were not saved at all. Well it turns out that while WebShell saves the data correctly, fetching our localStorage data with a key containing "Optional(key)" does not work, so force-unwrapping the key seems like the most feasible thing to do, which is exactly what this pull request does.
(There are still some weird problems with The Lounge, like not reading from localStorage at all sometimes, but at least session data is read correctly now. I might propose a few more pull requests if those problems are rooted in WebShell, not sure about it at the moment.)