Camera page updates

[dk307]

Summary by CodeRabbit

• New Features

  • Live View is now the default camera detail tab.
  • Added dedicated tabs for Live View, Timeline, and Details.
  • Improved live stream support for different remote connection formats.
  • Manual connection retries now cancel pending automatic retries.

• Removed

  • Removed the Commands tab and its index management actions.

• Bug Fixes

  • Improved validation of incoming live stream messages for more reliable connections.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b0e083b0-21b2-4096-80c1-a8c3777b5d26

📥 Commits

Reviewing files that changed from the base of the PR and between 4212165 and 6c20660.

📒 Files selected for processing (2)

• tests/e2e/test_cameras.py
• tests/e2e/test_e2e.py

---

📝 Walkthrough

Walkthrough

The camera page now opens on Live View, retains Timeline and Details, and removes Commands. WebRTC signaling validates answer and ICE payloads, and manual retry clears automatic retry timers. Related tests now select tabs explicitly.

Changes

Camera live view

Layer / File(s)	Summary
Live stream signaling app/api/cameras.py, frontend/src/components/VideoStream.tsx	live_ws logs the requested stream source. VideoStream validates JSON and SDP answers, accepts structured or string ICE candidates, and clears pending automatic retries before manual reconnects.
Camera page tabs and tests frontend/src/pages/CameraDetail.tsx, frontend/src/pages/CameraDetail.test.tsx, tests/e2e/test_cameras.py, tests/e2e/test_e2e.py	Live View is the default tab. Timeline and Details remain available. The Commands panel and its mutations are removed. Unit and end-to-end tests select Timeline explicitly, and Commands tests are removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CameraDetail
  participant VideoStream
  participant live_ws
  participant go2rtc
  CameraDetail->>VideoStream: Render Live View tab
  VideoStream->>live_ws: Request stream source
  live_ws->>go2rtc: Check stream availability
  live_ws-->>VideoStream: Send signaling data
  VideoStream->>VideoStream: Validate SDP and ICE payloads

Loading

Possibly related PRs

• dk307/HomeTimeline#6: Introduced the CameraDetail.tsx Commands panel and camera page structure changed here.
• dk307/HomeTimeline#9: Added related live-view WebSocket and camera-page integration.
• dk307/HomeTimeline#13: Updated CameraDetail.test.tsx for related camera page behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title relates to the changed camera page but does not identify the main tab and Live View changes.	Use a more specific title, such as "Make Live View the default camera tab and remove Commands".

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch camera_page

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
__init__.py	0	0	100%
build_info.py	5	0	100%
config.py	24	0	100%
database.py	23	1	96%	39
main.py	82	13	84%	49–50, 58, 133–135, 137–142, 144
api
__init__.py	0	0	100%
activity.py	24	0	100%
app_settings.py	27	0	100%
cameras.py	373	16	96%	233, 235, 237, 241, 523–526, 534–537, 541, 582, 614–615
health.py	34	3	91%	17–19
locations.py	38	0	100%
logs.py	28	0	100%
recordings.py	142	1	99%	88
scanner.py	28	0	100%
storage.py	6	0	100%
system_info.py	137	1	99%	33
timeline.py	29	0	100%
models
__init__.py	0	0	100%
app_settings.py	13	0	100%
base.py	8	0	100%
camera.py	32	0	100%
download_event.py	14	0	100%
location.py	9	0	100%
purge_event.py	14	0	100%
recording.py	38	1	97%	56
scan_event.py	14	0	100%
schemas
__init__.py	0	0	100%
app_settings.py	6	0	100%
camera.py	99	0	100%
location.py	11	0	100%
recording.py	8	0	100%
services
__init__.py	0	0	100%
downloader.py	156	2	99%	324–325
go2rtc.py	281	0	100%
hikvision.py	175	2	99%	154–155
log_buffer.py	63	2	97%	77–78
purger.py	140	0	100%
reconcile.py	17	0	100%
scanner.py	273	3	99%	347, 373, 435
storage.py	22	0	100%
tz.py	54	0	100%
workers
__init__.py	0	0	100%
scheduler.py	123	0	100%
TOTAL	2570	45	98%

[codecov]

Codecov Report

❌ Patch coverage is 56.66667% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.88%. Comparing base (f0a59b2) to head (6c20660).

Files with missing lines	Patch %	Lines
frontend/src/components/VideoStream.tsx	40.90%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   93.04%   92.88%   -0.17%     
==========================================
  Files          81       81              
  Lines        7438     7377      -61     
  Branches      755      751       -4     
==========================================
- Hits         6921     6852      -69     
- Misses        483      491       +8     
  Partials       34       34              

Flag	Coverage Δ
backend	98.24% <100.00%> (-0.04%)	⬇️
frontend	90.01% <55.17%> (-0.28%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.