restore value_stringId usage - #5057
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restores value_stringId parsing for NAMETEXTID / TOOLTIPTEXTID configuration fields across several config loaders, allowing these fields to be specified via string aliases (and numeric IDs) rather than being treated as plain default numeric parsing.
Changes:
- Switched multiple
*TEXTIDfields fromvalue_defaulttovalue_stringIdin trap/door, terrain, objects, magic, and computer-player config parsing. - Restored consistent parsing behavior for tooltip/name string IDs across these subsystems.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/config_trapdoor.c | Restores value_stringId for door/trap name + tooltip text IDs. |
| src/config_terrain.c | Restores value_stringId for slab/room tooltip + name text IDs. |
| src/config_objects.c | Restores value_stringId for object tooltip text ID. |
| src/config_magic.c | Restores value_stringId for power name + tooltip text IDs. |
| src/config_compp.c | Restores value_stringId for computer-player tooltip text ID. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+302
to
+303
| {"NAMETEXTID", 0, field_t(struct TrapConfigStats, name_stridx), 0, INT32_MIN, UINT32_MAX, NULL, value_stringId, assign_default}, | ||
| {"TOOLTIPTEXTID", 0, field_t(struct TrapConfigStats, tooltip_stridx), 0, INT32_MIN, UINT32_MAX, NULL, value_stringId, assign_tooltip_idx_trap}, |
Comment on lines
+506
to
+507
| {"NAMETEXTID", 0, field_t(struct PowerConfigStats, name_stridx), 0, INT32_MIN,UINT32_MAX, NULL, value_stringId, assign_default}, | ||
| {"TOOLTIPTEXTID", 0, field_t(struct PowerConfigStats, tooltip_stridx), 0, INT32_MIN,UINT32_MAX, NULL, value_stringId, assign_default}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.