Skip to content

Conversation

@MartinNowak
Copy link
Member

@MartinNowak MartinNowak commented Jun 8, 2017

- now a built-in feature of Travis-CI
@MartinNowak MartinNowak requested a review from wilzbach June 9, 2017 11:34
Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think #55 needs access to the travis API, but rebasing the PR shouldn't be hard.

trelloSecret = environment["TRELLO_SECRET"];
trelloAuth = "key="~environment["TRELLO_KEY"]~"&token="~environment["TRELLO_TOKEN"];
hookSecret = environment["GH_HOOK_SECRET"];
travisAuth = "token " ~ environment["TRAVIS_TOKEN"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So don't remove TRAVIS_TOKEN yet ;-)

@dlang-bot dlang-bot merged commit 9c60f50 into dlang:master Jun 9, 2017
@MartinNowak MartinNowak deleted the rm_travis branch June 9, 2017 12:21
@wilzbach
Copy link
Contributor

Hmm I think we need to revert this as the feature at Travis CI doesn't seem to work as intended:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Travis has implemented auto-dedup

3 participants