Skip to content

remove travis CI build canceler #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2017
Merged

remove travis CI build canceler #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ Features

- [Automated bugzilla, github, and trello references](#automated-references)
- [Auto-merging approved & passing PRs](#auto-merge)
- [Canceling stale Travis-CI builds](#canceling-stale)


<a name="automated-references" />

Expand Down Expand Up @@ -101,10 +99,3 @@ _Note_: at the moment the Dlang-Bot doesn't store _any_ authentication token, so
it can't perform actions on behalf of others.

<a name="canceling-state" />

Canceling stale Travis-CI builds
--------------------------------

To avoid wasteful resource consumption with Travis CI,
the Dlang-Bot will automatically cancel the previous, possibly running build of
a PR on a new commit event (push or synchronization by a user).
7 changes: 1 addition & 6 deletions source/dlangbot/app.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
module dlangbot.app;

import dlangbot.bugzilla, dlangbot.github, dlangbot.travis, dlangbot.trello,
import dlangbot.bugzilla, dlangbot.github, dlangbot.trello,
dlangbot.utils;

public import dlangbot.bugzilla : bugzillaURL;
public import dlangbot.github : githubAPIURL, githubAuth, hookSecret;
public import dlangbot.travis : travisAPIURL;
public import dlangbot.trello : trelloAPIURL, trelloAuth, trelloSecret;

string cronDailySecret;
Expand Down Expand Up @@ -45,7 +44,6 @@ shared static this()
trelloSecret = environment["TRELLO_SECRET"];
trelloAuth = "key="~environment["TRELLO_KEY"]~"&token="~environment["TRELLO_TOKEN"];
hookSecret = environment["GH_HOOK_SECRET"];
travisAuth = "token " ~ environment["TRAVIS_TOKEN"];
Copy link
Contributor

@wilzbach wilzbach Jun 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So don't remove TRAVIS_TOKEN yet ;-)

cronDailySecret = environment["CRON_DAILY_SECRET"];

// workaround for stupid openssl.conf on Heroku
Expand Down Expand Up @@ -214,7 +212,4 @@ void handlePR(string action, PullRequest* _pr)

if (runTrello)
updateTrelloCard(action, pr.htmlURL, refs, descs);

// wait until builds for the current push are created
setTimer(30.seconds, { dedupTravisBuilds(action, pr.repoSlug, pr.number); });
}
66 changes: 0 additions & 66 deletions source/dlangbot/travis.d
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/utils.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ void startFakeAPIServer()

githubAPIURL = fakeAPIServerURL ~ "/github";
trelloAPIURL = fakeAPIServerURL ~ "/trello";
travisAPIURL = fakeAPIServerURL ~ "/travis";
bugzillaURL = fakeAPIServerURL ~ "/bugzilla";
}

Expand Down