Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jun 22, 2017

I am having a really hard to to see whether everything is work as supposed.
In any case, logging is cheap and it's better to have the history in case something didn't go as expected ...

@dlang-bot
Copy link
Collaborator

dlang-bot commented Jun 22, 2017

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some things that can help to speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

@wilzbach wilzbach closed this Jun 22, 2017
@wilzbach wilzbach reopened this Jun 22, 2017
@dlang dlang deleted a comment from dlang-bot Jun 22, 2017
@wilzbach wilzbach closed this Jun 22, 2017
@wilzbach wilzbach reopened this Jun 22, 2017
@wilzbach
Copy link
Contributor Author

This is would be very helpful now (and it just adds a couple of log messages) -> merging.

@dlang-bot dlang-bot merged commit e7953ec into dlang:master Jun 22, 2017
@wilzbach wilzbach deleted the more-logging branch June 22, 2017 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants