Skip to content

Conversation

@RazvanN7
Copy link
Contributor

After [1] is merged and @future is documented, this addition should be the next step.

[1] dlang/dmd#7232

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RazvanN7
Copy link
Contributor Author

@andralex all the other true/false occurrences are highlighted with $D. Anyway, it's not important...

@dlang-bot dlang-bot merged commit 7a608bf into dlang:master Oct 24, 2017
@andralex
Copy link
Member

Yah, most of the docs predate the introduction of the backticks feature. This gave me the idea of dlang/phobos#5801.


$(P Takes one argument. It returns `true` if the argument is a symbol
marked with the `@future` keyword, otherwise `false`. Currently, only
functions and variable declarations have support for the `@future` keyword.)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth noting that this is an experimental feature. To the point that it's not even @future yet, but @__future (IIRC). Also, I think we should strongly state that this is not intended for user code yet, and link to the DIP.

I think this feature is having too much visibility and too little clarity for an experimental feature...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants