Try fixing code coverage with relative paths#10520
Merged
dlang-bot merged 1 commit intodlang:masterfrom Oct 31, 2019
Merged
Conversation
Contributor
|
Nice! Looks like you found the issue! |
wilzbach
reviewed
Oct 31, 2019
marler8997
force-pushed
the
fixCodeCov
branch
from
a5aff33 to
0c5b29c
Compare
wilzbach
approved these changes
Oct 31, 2019
src/build.d
Outdated
| ].chain(extraFlags, platformArgs, flags["DFLAGS"], sources).array; | ||
| ].chain(extraFlags, platformArgs, flags["DFLAGS"], | ||
| // source files need to have relative paths in order for the code coverage | ||
| // .lst files to be named properly for circle CI to find them |
Contributor
There was a problem hiding this comment.
It's technically CodeCov (it's just run one Circle CI)
marler8997
force-pushed
the
fixCodeCov
branch
from
0c5b29c to
f262b28
Compare
Contributor
|
Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10520" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code coverage is broken since we moved building the dmd executable from the makefile to
build.d(#10446). After some digging I noticed that filenames of the*.lstfiles generated from running an exe with-covare based on the source filenames passed to the compiler on the command-line. The makefiles were using relative paths andbuild.duses absolute paths, so I've switchedbuild.dto use relative paths in this case to see if it fixes the issue.