Skip to content

Comments

Improve code coverage a bit more by enabling it in the lexer library#10523

Merged
dlang-bot merged 1 commit intodlang:masterfrom
marler8997:checkCov
Oct 31, 2019
Merged

Improve code coverage a bit more by enabling it in the lexer library#10523
dlang-bot merged 1 commit intodlang:masterfrom
marler8997:checkCov

Conversation

@marler8997
Copy link
Contributor

No description provided.

@marler8997 marler8997 changed the title Just checking if this helps code coverage Improve code coverage a bit more by enabling it in the lexer library Oct 31, 2019
@marler8997 marler8997 marked this pull request as ready for review October 31, 2019 10:34
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10523"

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage went up to 82.2% (+2.918%), almost the level same as before the regression (82.38%), nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants