Move avg and impvisitor examples to test/dub_package#10552
Move avg and impvisitor examples to test/dub_package#10552dlang-bot merged 1 commit intodlang:masterfrom
Conversation
bae9741 to
08f3597
Compare
3438fa3 to
29423fc
Compare
|
Sorry, but as the last PR was merged so quickly without a discussion I think I have to be harsher here. |
|
@wilzbach I'm confused, this PR is moving the examples to test/dub_packages like you asked. Why did you close it? |
|
Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10552" |
wilzbach
left a comment
There was a problem hiding this comment.
I'm sorry, I was too fast here.
|
Maybe remove the corresponding Lines 552 to 558 in 65d4a7c |
56c5237 to
247b012
Compare
247b012 to
fa34234
Compare
With this change the
avgandimpvisitorexamples are now tested byci.shinstead of from the Makefiles. This is a result of a suggestion from @wilzbach (#10504 (comment))Note that I modified
ci.shto only buildimpvisitor.dinstead of also running it. This is because it fails to run because of:However, we currently aren't running impvisitor anyway.