IGNOREME: just trying to figure out why autotester win32 is mangling pathnames

[marler8997]

It looks like this failure occurs on some autotester Win_32 hosts but not on others. Consistently fails on the "power" host but succeeds on the "win-farm-1" host.

The failure occurs when running git to clone the dlang tools repo. It fails with a message indicating that it combined the current directory with the absolute path passed as the destination path for the repo, i.e.

Run: git clone --depth=1 https://github.com/dlang/tools C:\cygwin\home\braddr\sandbox\at-client\pull-3836022-Win_32\tools
Cloning into 'C:\cygwin\home\braddr\sandbox\at-client\pull-3836022-Win_32\tools'...
fatal: Invalid path '/home/braddr/sandbox/at-client/pull-3836022-Win_32/dmd/src/C:\cygwin\home\braddr\sandbox\at-client\pull-3836022-Win_32\tools': No such file or directory

@braddr confirms these machines are using git directly (there's no in-between script that could be mangling the arguments). It seems the most likely culprit is cygwin. I've emailed @braddr to ask whether these machines are using different versions of cygwin.

Ping @MoonlightSentinel

[dlang-bot]

Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10567"

[marler8997]

What the heck is going on! How is it passing now???

[rainers]

What the heck is going on! How is it passing now???

It's back to failure. I guess it depends on the build machine, passing for "win-farm-1", but failing for "power". The difference in the log is that HOST_DMD is initially not set in the passing version.

[marler8997]

Not sure how HOST_DMD would affect the git clone command. Might be a different version of cygwin causing the issue?

[rainers]

Not sure how HOST_DMD would affect the git clone command.

I'm not sure either. Is the error message actually from git clone or when trying to compile and run checkwhitespace?

Might be a different version of cygwin causing the issue?

Possible. I've long given up on cygwin, in part due to this brittle conversion of path names,

[MoonlightSentinel]

I'm not sure either. Is the error message actually from git clone or when trying to compile and run checkwhitespace?

Yes:
writefln in commandFunction:

cloning tools repo to 'C:\cygwin\home\braddr\sandbox\at-client\pull-3836022-Win_32\tools'...

run (output in verbose mode):

Run: git clone --depth=1 https://github.com/dlang/tools C:\cygwin\home\braddr\sandbox\at-client\pull-3836022-Win_32\tools

Git:

Cloning into 'C:\cygwin\home\braddr\sandbox\at-client\pull-3836022-Win_32\tools'...
fatal: Invalid path '/home/braddr/sandbox/at-client/pull-3836022-Win_32/dmd/src/C:\cygwin\home\braddr\sandbox\at-client\pull-3836022-Win_32\tools': No such file or directory

Not sure how HOST_DMD would affect the git clone command. Might be a different version of cygwin causing the issue?

Probably. Is style executed on this machine (as it also contains a git clone) ?