Skip to content

Comments

build.d: Add condition delegate#10589

Merged
thewilsonator merged 1 commit intodlang:masterfrom
marler8997:depConditions
Nov 20, 2019
Merged

build.d: Add condition delegate#10589
thewilsonator merged 1 commit intodlang:masterfrom
marler8997:depConditions

Conversation

@marler8997
Copy link
Contributor

@marler8997 marler8997 commented Nov 18, 2019

Currently when you run build.d it will re-run some of the dependencies every time. This is because some rules don't use file timestamps determine whether or not they should run. This change adds the condition property to the Dependency object that is used to determine whether or not the rule needs to be run.

This means we can still use the msg property and it will only be printed when the dependency is actually executed.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10589"

@marler8997 marler8997 force-pushed the depConditions branch 2 times, most recently from 16114f8 to 6cda33e Compare November 18, 2019 20:11
@thewilsonator
Copy link
Contributor

Auto-merge toggled on

@thewilsonator thewilsonator merged commit da10860 into dlang:master Nov 20, 2019
@marler8997 marler8997 deleted the depConditions branch May 29, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants