Skip to content

Comments

Remove scp target from win32.mak#10608

Merged
dlang-bot merged 1 commit intodlang:masterfrom
marler8997:removeScp
Nov 23, 2019
Merged

Remove scp target from win32.mak#10608
dlang-bot merged 1 commit intodlang:masterfrom
marler8997:removeScp

Conversation

@marler8997
Copy link
Contributor

@marler8997 marler8997 commented Nov 22, 2019

Instead of moving the scp target to build.d, @wilzbach indicates (#10606 (review)) it is no longer used so can be removed.

This is one of the last targets in win32.mak holding a reference to the source file lists in it. Once we finish removing these last targets, we can remove the redundant source lists.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10608"

Copy link
Contributor

@MoonlightSentinel MoonlightSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove scp from the targets list

@dlang-bot dlang-bot merged commit c37827a into dlang:master Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants