Skip to content

Comments

support VERBOSE=1 from makefiles#10669

Merged
dlang-bot merged 1 commit intodlang:masterfrom
marler8997:makeVerbose
Dec 15, 2019
Merged

support VERBOSE=1 from makefiles#10669
dlang-bot merged 1 commit intodlang:masterfrom
marler8997:makeVerbose

Conversation

@marler8997
Copy link
Contributor

@marler8997 marler8997 commented Dec 14, 2019

This allows makefile users to see verbose build output with make VERBOSE=1.

Note that the posix version of the makefiles don't need any changes because GNU make automatically promotes variables set on the command-line to environment variables. This means they will propagate down to the build.d process. However, Digital Mars Make on windows does not set them as environment variables, so they must be explicitly propagated each time make is recursively called and when we call build.d.

Side Note: windows makefiles are missing some variables that need to be propagated, something that we should fix in another change.

That being said, I wasn't able to edit the root makefiles win32.mak and win64.mak to propagate the VERBOSE variable because autotester kept giving me errors like this:

Error on line 3: expecting target : dependencies

https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3867801&isPull=true
https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3867802&isPull=true
https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3867859&isPull=true
https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3867868&isPull=true

It looks like the autotester is depending on those files to look a certain way. So on windows, I could only make the VERBOSE flag work if you invoke make on src/win32.mak or src/win64.mak directly.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10669"

@marler8997 marler8997 force-pushed the makeVerbose branch 2 times, most recently from 1390635 to 35f4310 Compare December 14, 2019 18:47
@dlang-bot dlang-bot merged commit 5577015 into dlang:master Dec 15, 2019
@marler8997 marler8997 deleted the makeVerbose branch December 15, 2019 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants