support VERBOSE=1 from makefiles#10669
Merged
dlang-bot merged 1 commit intodlang:masterfrom Dec 15, 2019
Merged
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10669" |
1390635 to
35f4310
Compare
35f4310 to
2f9f637
Compare
thewilsonator
approved these changes
Dec 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows makefile users to see verbose build output with
make VERBOSE=1.Note that the posix version of the makefiles don't need any changes because GNU make automatically promotes variables set on the command-line to environment variables. This means they will propagate down to the
build.dprocess. However, Digital Mars Make on windows does not set them as environment variables, so they must be explicitly propagated each time make is recursively called and when we callbuild.d.That being said, I wasn't able to edit the root makefiles
win32.makandwin64.makto propagate theVERBOSEvariable because autotester kept giving me errors like this:https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3867801&isPull=true
https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3867802&isPull=true
https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3867859&isPull=true
https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3867868&isPull=true
It looks like the autotester is depending on those files to look a certain way. So on windows, I could only make the
VERBOSEflag work if you invoke make onsrc/win32.makorsrc/win64.makdirectly.