Improve static array initializer checks#14513
Open
ntrel wants to merge 3 commits intodlang:masterfrom
Open
Conversation
Disallow null literal runtime initializer (except as element). Disallow `init` as initializer when static array length > 0. Allow `init` as initializer for global static array regardless of length.
thewilsonator
approved these changes
Oct 3, 2022
RazvanN7
approved these changes
Oct 6, 2022
Contributor
|
This requires a changelog entry. |
ljmf00
added
the
Review:Needs Changelog
Contributor
|
@ntrel Could you please add a changelog entry? |
Contributor
Why? I don't understand why this should be legal: int[1] a3 = (int[]).init; // ok
|
Contributor
|
ping @ntrel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DisallowDeprecate null literal runtime SA initializer (except as an element initializer when element type accepts null). Rationale in bug below.Disallow
initas runtime SA initializer when static array length > 0.Allow
initas initializer for global static array regardless of length.Fix Issue 23381 - init as initializer of 0-sized static array