Attempt to use longdouble_soft everywhere I can see.#14696
Open
maxhaton wants to merge 1 commit intodlang:masterfrom
Open
Attempt to use longdouble_soft everywhere I can see.#14696maxhaton wants to merge 1 commit intodlang:masterfrom
maxhaton wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @maxhaton! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14696" |
Member
Author
|
Slightly apprehensive about windows dmd builds |
maxhaton
force-pushed
the
longdoubleeverywhere
branch
2 times, most recently
from
71ee538 to
55c5fba
Compare
This does not yet mean that we are truly emulating things yet but this makes it much easier to emulate things when the code to do so is ready. The fstp fld mixins were wrong for 64 bit linux (at least) and have been changed. Now we see what the test-suite says Minor change/s have had to be made to enable betterC compilation on older compiler for bootstrapping
maxhaton
force-pushed
the
longdoubleeverywhere
branch
from
55c5fba to
7852d4b
Compare
ibuclaw
reviewed
Dec 15, 2022
Comment on lines
-232
to
-239
| return "asm nothrow @nogc pure @trusted { mov RAX, " ~ arg ~ "; fld real ptr [RAX]; }"; | ||
| return "asm nothrow @nogc pure @trusted { lea RAX, " ~ arg ~ "; fld real ptr [RAX]; }"; | ||
| } | ||
| string fstp_arg(string arg)() | ||
| { | ||
| return "asm nothrow @nogc pure @trusted { lea RAX, " ~ arg ~ "; fstp real ptr [RAX]; }"; | ||
| } | ||
| string fld_parg(string arg)() | ||
| { | ||
| return "asm nothrow @nogc pure @trusted { mov RAX, " ~ arg ~ "; fld real ptr [RAX]; }"; | ||
| } | ||
| string fstp_parg(string arg)() | ||
| { | ||
| return "asm nothrow @nogc pure @trusted { mov RAX, " ~ arg ~ "; fstp real ptr [RAX]; }"; | ||
| } | ||
| alias fld_parg = fld_arg; | ||
| alias fstp_parg = fstp_arg; |
Member
There was a problem hiding this comment.
You likely are going to have to split this between MSVC and X86 (mov), and Posix x86_64 (lea).
Member
Author
There was a problem hiding this comment.
Is there a gdc friendly equivalent of the version(LDC) code? Don't really want so much inline asm if possible
Member
There was a problem hiding this comment.
I think this is equivalent, LDC also accepts it and compiles to the same code.
Contributor
|
@maxhaton any updates on this? |
Member
Author
|
Working on gdc code for the asm
…On Wed, 21 Dec 2022, 13:15 Razvan Nitu, ***@***.***> wrote:
@maxhaton <https://github.com/maxhaton> any updates on this?
—
Reply to this email directly, view it on GitHub
<#14696 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLI75A2FKB56Q6HE25I4XLWOL7HPANCNFSM6AAAAAAS7DOKVM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not yet mean that we are truly emulating things yet but this makes it much easier to emulate things when the code to do so is ready.
The fstp fld mixins were wrong for 64 bit linux (at least) and have been changed. Now we see what the test-suite says