Skip to content

Comments

optimize idPool() a bit#15206

Merged
dlang-bot merged 1 commit intodlang:masterfrom
WalterBright:identx
May 9, 2023
Merged

optimize idPool() a bit#15206
dlang-bot merged 1 commit intodlang:masterfrom
WalterBright:identx

Conversation

@WalterBright
Copy link
Member

You see... a while back, I was walking down the yellow brick road and noticed that the idPool function had remnants of the old C version of the implementation. Thought I'd fix it by:

  1. removing the ptr/length interface, except for the C++ entry point
  2. use a default value instead of a forwarding function
  3. recognize that one of the overloads was only used for keyword setup
  4. remove 32 bit legacy cast to uint
  5. add some clarifying documentation

@WalterBright WalterBright added Review:Easy Review Feature:ImportC Pertaining to ImportC support labels May 9, 2023
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15206"

@WalterBright WalterBright force-pushed the identx branch 2 times, most recently from e6b03a4 to abba868 Compare May 9, 2023 04:56
@dlang-bot dlang-bot merged commit 591242e into dlang:master May 9, 2023
@WalterBright WalterBright deleted the identx branch May 9, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants