Skip to content

Comments

Encapsulate Loc member access#15211

Merged
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:loc-encapsulate
May 9, 2023
Merged

Encapsulate Loc member access#15211
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:loc-encapsulate

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented May 9, 2023

Using functions instead of direct field access allows Loc to change its internals more easily, which helps with the recent effort to reduce its size: struct Location size

@dkorpel dkorpel added the Severity:Refactoring No semantic changes to code label May 9, 2023
@dkorpel dkorpel requested a review from ibuclaw as a code owner May 9, 2023 12:42
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15211"

@ibuclaw
Copy link
Member

ibuclaw commented May 9, 2023

Loc could be replaced with a uint (index into an array, or hash table), then it's internals (and size) will be completely hidden.

@dkorpel
Copy link
Contributor Author

dkorpel commented May 9, 2023

Loc could be replaced with a uint (index into an array, or hash table)

Yes, that's the plan

@dlang-bot dlang-bot merged commit 37c51f2 into dlang:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Severity:Refactoring No semantic changes to code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants