Skip to content

Comments

Don't allocate argument list on the stack#15213

Merged
RazvanN7 merged 1 commit intodlang:masterfrom
dkorpel:stack-arrays-1
May 11, 2023
Merged

Don't allocate argument list on the stack#15213
RazvanN7 merged 1 commit intodlang:masterfrom
dkorpel:stack-arrays-1

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented May 9, 2023

Similar to #15204

functionResolve can escape its argumentList parameter, so don't pass it a stack pointer

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15213"

@dkorpel dkorpel changed the title opover.d: Don't allocate argument list on the stack Don't allocate argument list on the stack May 9, 2023
@RazvanN7 RazvanN7 merged commit 04306b4 into dlang:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants