Skip to content

Comments

Turn overloading extern(C) functions into an error#15217

Merged
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:overload-cpp-deprecation-error
May 10, 2023
Merged

Turn overloading extern(C) functions into an error#15217
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:overload-cpp-deprecation-error

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented May 10, 2023

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15217"

@dkorpel dkorpel force-pushed the overload-cpp-deprecation-error branch from bc724fd to 10b27b0 Compare May 10, 2023 13:20
@dlang-bot dlang-bot merged commit 928a03b into dlang:master May 10, 2023
@dkorpel dkorpel deleted the overload-cpp-deprecation-error branch May 10, 2023 21:15
@PetarKirov
Copy link
Member

Overloading based on type qualifier is still supported for extern (C) right? We have such functions in core.sys e.g. sync primtives that accept both shared and non-shared args (the latter for backwards compatibility).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants