Skip to content

Comments

Remove ph2.d#15220

Closed
dkorpel wants to merge 1 commit intodlang:masterfrom
dkorpel:remove-ph2
Closed

Remove ph2.d#15220
dkorpel wants to merge 1 commit intodlang:masterfrom
dkorpel:remove-ph2

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented May 10, 2023

The module comment says "A leaking bump-the-pointer allocator - This is only for dmd, not dmc." but it's used nowhere.

@dkorpel dkorpel added Severity:Refactoring No semantic changes to code Compiler:Backend glue code, optimizer, code generation labels May 10, 2023
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15220"

@dkorpel
Copy link
Contributor Author

dkorpel commented May 10, 2023

Nevermind, it's used on Windows

@dkorpel dkorpel closed this May 10, 2023
@dkorpel dkorpel mentioned this pull request May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compiler:Backend glue code, optimizer, code generation Severity:Refactoring No semantic changes to code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants