Skip to content

Comments

Consolidate frontend 'imports' of the backend#15228

Merged
dkorpel merged 1 commit intodlang:masterfrom
dkorpel:backend-frontend-imports
May 11, 2023
Merged

Consolidate frontend 'imports' of the backend#15228
dkorpel merged 1 commit intodlang:masterfrom
dkorpel:backend-frontend-imports

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented May 11, 2023

I thought the backend was not allowed to import anything from dmd or dmd/root, but through extern function declarations, it depends on dmd/dmsc.d, dmd/eh.d, and dmd/e2ir.d. I'm not sure of the best solution for this yet, so simply put them all together for now.

@dkorpel dkorpel added Severity:Refactoring No semantic changes to code Compiler:Backend glue code, optimizer, code generation labels May 11, 2023
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15228"

@dkorpel dkorpel force-pushed the backend-frontend-imports branch from 9135b62 to 05ebfc7 Compare May 11, 2023 15:34
@dkorpel dkorpel merged commit f8d118d into dlang:master May 11, 2023
@dkorpel dkorpel deleted the backend-frontend-imports branch May 11, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compiler:Backend glue code, optimizer, code generation Severity:Refactoring No semantic changes to code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants