Skip to content

Comments

Simplify opcost table generation#15230

Merged
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:simpler-opcost
May 11, 2023
Merged

Simplify opcost table generation#15230
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:simpler-opcost

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented May 11, 2023

With ldc's -ftime-trace I noticed this CTFE execution being needlessly inefficient, with unnecessary nested for loops. I used a static assert to verify that the old and new function produce the exact same array.

@dkorpel dkorpel added Severity:Refactoring No semantic changes to code Compiler:Backend glue code, optimizer, code generation labels May 11, 2023
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15230"

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch.

@dlang-bot dlang-bot merged commit 1b86499 into dlang:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compiler:Backend glue code, optimizer, code generation Merge:auto-merge Severity:Refactoring No semantic changes to code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants