Actually enable -preview=fieldwise by default#20670
Actually enable -preview=fieldwise by default#20670pbackus wants to merge 1 commit intodlang:masterfrom
Conversation
This change was accidentally left out of PR dlang#17495.
|
Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#20670" |
|
@ryuukk Workaround is to define a BetterC-compatible |
|
Unfortunately this looks like it opens a huge can of worms, so maybe better to delay for now. |
|
The |
This reverts commit 6a7bd45. PR dlang#17495 was originally merged in an incomplete state. Since there are non-trivial obstacles to completing it, revert the incomplete changes instead. See PR dlang#20670 for more information.
|
Closing in favor of #20672 |
|
@ryuukk Do you have a self-contained test case for that error? Adding that to the test suite would prevent accidentally breaking your project in the future. |
|
@dkorpel The error happens because with |
|
What are the types of items[i].attributes and item.attributes? |
|
Relevant issue is #18197 |
This change was accidentally left out of PR #17495.