Skip to content

Remove unused RTLSYM.NEWARRAYMTX#21011

Merged
thewilsonator merged 1 commit intodlang:masterfrom
nybzmr:remove-unused-rtlsym
Mar 17, 2025
Merged

Remove unused RTLSYM.NEWARRAYMTX#21011
thewilsonator merged 1 commit intodlang:masterfrom
nybzmr:remove-unused-rtlsym

Conversation

@nybzmr
Copy link
Contributor

@nybzmr nybzmr commented Mar 17, 2025

RTLSYM.NEWARRAYMTX was removed as it is no longer used in e2ir.d or anywhere else.

@dlang-bot
Copy link
Contributor

dlang-bot commented Mar 17, 2025

Thanks for your pull request and interest in making D better, @nybzmr! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21011"

@nybzmr nybzmr changed the base branch from master to stable March 17, 2025 08:01
@nybzmr nybzmr requested a review from ibuclaw as a code owner March 17, 2025 08:01
Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a bug fix, so please don't target stable. The change needs rebasing as well to remove unrelated commits.

@nybzmr
Copy link
Contributor Author

nybzmr commented Mar 17, 2025

@teodutu Could you review this PR when you have time? Let me know if I missed anything. Thanks!

@nybzmr nybzmr changed the base branch from stable to master March 17, 2025 08:10
@nybzmr nybzmr force-pushed the remove-unused-rtlsym branch from c8e7cec to 9cb4f68 Compare March 17, 2025 08:23
@nybzmr
Copy link
Contributor Author

nybzmr commented Mar 17, 2025

I have rebased to the latest master. Let me know if you need any further changes :)

@thewilsonator thewilsonator dismissed ibuclaw’s stale review March 17, 2025 08:31

PR targets master now

@thewilsonator thewilsonator merged commit a4cbc08 into dlang:master Mar 17, 2025
39 of 42 checks passed
@teodutu
Copy link
Member

teodutu commented Mar 17, 2025

Thanks @nybzmr. You can also remove NEWARRAYMITX, TRACENEWARRAYMTX, and TRACENEWARRAYMITX. The latter 2 are the old wrapper hooks used to trace GC allocations for profiling. In addition to e2ir.d and drtslym.d, also remove these symbols from the enum RTLSYM:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants