Skip to content

Conversation

@abulgit
Copy link
Contributor

@abulgit abulgit commented Mar 27, 2025

Fix: #21094
Improve the PR: #21001 (Fix: Prevent ICE on final switch forward referencing its enum)
I set ed.semanticRun = PASS.semantic2done at the end of the C enum processing

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @abulgit! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21097"

@dkorpel
Copy link
Contributor

dkorpel commented Mar 27, 2025

Cool, can you add a test case in test/compilable?

@dkorpel dkorpel merged commit 228f8db into dlang:master Mar 28, 2025
42 checks passed
shivangshukla7020 pushed a commit to shivangshukla7020/dmd that referenced this pull request Mar 30, 2025
…enum. (dlang#21097)

* Mark C enums as semantic2done to prevent segfaults in final switch

* Added corresponding test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants