Extracted Dsymbol.hasPointers to visitor in dsymbolsem#21140
Extracted Dsymbol.hasPointers to visitor in dsymbolsem#21140thewilsonator merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @MatthewQiu-5! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#21140" |
54be009 to
9fca095
Compare
| /***************************************** | ||
| * Is Dsymbol a variable that contains pointers? | ||
| */ | ||
| bool hasPointers(Dsymbol d) |
There was a problem hiding this comment.
This is used by LDC so it actually needs to remain extern(C++) despite what Iain said. When you add this back to the C++ interface, add it to the dmd namespace, not the global one.
There was a problem hiding this comment.
@thewilsonator this is correct. top-level symbol is extern(D). The exported C++ symbol is in the dmd namespace in cxxfrontend.d.
Used by LDC, required to be in the C++ interface
|
This has merge conflicts, please rebase. |
thewilsonator
left a comment
There was a problem hiding this comment.
Apart from the style comments from Iain and the merge conflict, this looks good.
9fca095 to
4e5aa60
Compare
4e5aa60 to
82162d4
Compare
Part of the project to separate semantic routines from AST nodes: https://github.com/dlang/project-ideas/blob/master/separate-semantic-routines-from-ast-nodes/description.md
@RazvanN7