Skip to content

[stable] Tests: Make fail_compilation/failexpression{3,4}.d work for targets with 64-bit real#22206

Merged
thewilsonator merged 1 commit intodlang:stablefrom
kinke:failexpression_float
Dec 8, 2025
Merged

[stable] Tests: Make fail_compilation/failexpression{3,4}.d work for targets with 64-bit real#22206
thewilsonator merged 1 commit intodlang:stablefrom
kinke:failexpression_float

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Dec 8, 2025

The tested type combinations were trimmed with static if statements, causing real to effectively not be tested at all unless its size is 64 bits, then making the test fail because of the extra output.

Make these 2 tests target-agnostic by simply testing all combinations.

…ith 64-bit real

The tested type combinations were trimmed with `static if` statements,
causing `real` to effectively not be tested at all *unless* its size is
64 bits, then making the test fail because of the extra output.

Make these 2 tests target-agnostic by simply testing all combinations.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#22206"

@kinke kinke requested a review from ibuclaw December 8, 2025 18:53
@thewilsonator thewilsonator merged commit 46a7a09 into dlang:stable Dec 8, 2025
76 of 80 checks passed
@kinke kinke deleted the failexpression_float branch December 9, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants