Skip to content

Clean up semanticTypeInfoMembers using local helper#22267

Merged
thewilsonator merged 1 commit into
dlang:masterfrom
gorsing:refactoring_semanticTypeInfoMembers
Dec 19, 2025
Merged

Clean up semanticTypeInfoMembers using local helper#22267
thewilsonator merged 1 commit into
dlang:masterfrom
gorsing:refactoring_semanticTypeInfoMembers

Conversation

@gorsing
Copy link
Copy Markdown
Contributor

@gorsing gorsing commented Dec 19, 2025

Description: Extracted duplicate semantic analysis logic for xeq and xcmp into a local runSemantic helper function. This reduces boilerplate code related to error gagging and state checks inside semanticTypeInfoMembers.

No functional changes, purely a refactor for readability.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @gorsing! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22267"

@gorsing gorsing changed the title Refactor semanticTypeInfoMembers to use local helper Clean up semanticTypeInfoMembers using local helper Dec 19, 2025
@thewilsonator thewilsonator merged commit c0f9613 into dlang:master Dec 19, 2025
30 of 41 checks passed
@gorsing gorsing deleted the refactoring_semanticTypeInfoMembers branch April 22, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants