Skip to content

Conversation

@gorsing
Copy link
Contributor

@gorsing gorsing commented Dec 24, 2025

Summary

This PR adds the contains predicate to Array in dmd.root.array and applies it to refactor semantic analysis logic.

In the compiler's semantic stages, we often use manual foreach loops combined with label-breaks to avoid duplicates. By introducing contains, we simplify this pattern, reducing cognitive load and making the programmer's intent explicit without introducing side-effect obfuscation.

Key Changes

  • dmd.root.array: Added contains method (and underlying find logic) to the Array struct.
  • dmd.semantic3: Refactored checkClosure to use a.contains(f). This replaces a manual loop and a labeled break, significantly cleaning up the logic for tracking captured nested functions.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @gorsing! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22300"

@dkorpel dkorpel merged commit 452bd37 into dlang:master Dec 24, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants