add Array.contains and refactor checkClosure in semantic3.d #22300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
containspredicate toArrayindmd.root.arrayand applies it to refactor semantic analysis logic.In the compiler's semantic stages, we often use manual
foreachloops combined with label-breaks to avoid duplicates. By introducingcontains, we simplify this pattern, reducing cognitive load and making the programmer's intent explicit without introducing side-effect obfuscation.Key Changes
containsmethod (and underlyingfindlogic) to theArraystruct.checkClosureto usea.contains(f). This replaces a manual loop and a labeledbreak, significantly cleaning up the logic for tracking captured nested functions.